Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): implement support for downloads #1596

Merged
merged 1 commit into from
Mar 31, 2020
Merged

browser(webkit): implement support for downloads #1596

merged 1 commit into from
Mar 31, 2020

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Mar 31, 2020 •
edited
Loading

yury-s
yury-s approved these changes Mar 31, 2020
View reviewed changes
browser_patches/webkit/patches/bootstrap.diff Outdated
+
+- (void)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename completionHandler:(void (^)(BOOL allowOverwrite, NSString *destination))completionHandler
+{
+ completionHandler(YES, @"/Users/pfeldman/tmp/DESTINATION_PATH");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more generic path, /tmp?

test/test.js Outdated
@@ -43,17 +43,17 @@ const testRunner = new TestRunner({
breakOnFailure: process.argv.indexOf('--break-on-failure') !== -1,
installCommonHelpers: false
});
testRunner.testModifier('skip', (t, condition) => condition && t.setMode(t.Modes.Skip));
testRunner.suiteModifier('skip', (s, condition) => condition && s.setMode(s.Modes.Skip));
testRunner.testModifier('skip', (t, condition) => condition && t.setSkipped(true));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad rebaseline?

@pavelfeldman pavelfeldman merged commit a2e1d4c into microsoft:master Mar 31, 2020
@pavelfeldman pavelfeldman deleted the be_download_wk branch April 17, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @yury-s