chore(testrunner): make most modifiers external #1581

dgozman · 2020-03-28T04:32:04Z

No description provided.

aslushnikov · 2020-03-28T04:38:49Z

test/test.js

 });
+testRunner.fdescribe = testRunner.describe.focus;


these should be installed as part of common helpers?

aslushnikov

Awesome!!

The only thing we discussed to remove .setup in favor of returning test object as a result of it().

dgozman · 2020-03-28T14:46:41Z

Awesome!!

The only thing we discussed to remove .setup in favor of returning test object as a result of it().

I will address that in a follow up.

aslushnikov reviewed Mar 28, 2020

View reviewed changes

test/test.js

});

testRunner.fdescribe = testRunner.describe.focus;

Copy link

Collaborator

aslushnikov Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be installed as part of common helpers?

aslushnikov approved these changes Mar 28, 2020

View reviewed changes

chore(testrunner): make most modifiers external

5a746c9

dgozman merged commit b85ab89 into microsoft:master Mar 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(testrunner): make most modifiers external #1581

chore(testrunner): make most modifiers external #1581

dgozman commented Mar 28, 2020

aslushnikov Mar 28, 2020

aslushnikov left a comment

dgozman commented Mar 28, 2020

chore(testrunner): make most modifiers external #1581

chore(testrunner): make most modifiers external #1581

Conversation

dgozman commented Mar 28, 2020

aslushnikov Mar 28, 2020

Choose a reason for hiding this comment

aslushnikov left a comment

Choose a reason for hiding this comment

dgozman commented Mar 28, 2020