Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Expose Rawer V8 coverage information #955

Closed
lukeapage opened this issue Feb 12, 2020 · 1 comment · Fixed by #976
Closed

[Feature] Expose Rawer V8 coverage information #955

lukeapage opened this issue Feb 12, 2020 · 1 comment · Fixed by #976

Comments

@lukeapage
Copy link

see also this issue from puppeteer: puppeteer/puppeteer#2136

I've been trying to get puppeteer-to-instanbul to work with playwright - and I see the puppeteer and playwright implementations are the same - but I'm not getting very good information back - playwright destroys function call information, collapses the ranges and doesn't record call counts - which makes the underlying library v8-to-istanbul (which is used afaik by the node teams and as an experimental feature in jest) not viable.

@pavelfeldman
Copy link
Member

Sounds good, we should expose raw V8 snapshot in CrCoverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants