Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REGRESSION]: support mac 10.14 on webkit #5833

Closed
3 tasks done
aslushnikov opened this issue Mar 16, 2021 · 1 comment
Closed
3 tasks done

[REGRESSION]: support mac 10.14 on webkit #5833

aslushnikov opened this issue Mar 16, 2021 · 1 comment
Assignees
@aslushnikov

Comments

@aslushnikov
Copy link
Collaborator

aslushnikov commented Mar 16, 2021 •
edited
Loading

Official webkit no longer supports Mac 10.14. However, we still want to download a latest good version of
WebKit for Mac 10.14 that supports all the good Playwright features.

Things to do:

  • fork our webkit fork - with the last known WebKit version that compiles on Mac 10.14
  • download a compatible webkit version on Mac 10.14
  • setup bots on Mac 10.14 to make sure things work
@aslushnikov aslushnikov self-assigned this Mar 16, 2021
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 16, 2021
@aslushnikov
devops: fork webkit into a separate browser
e94fe78 
Official WebKit no longer supports Mac 10.14. However, since
this system is still very much in use, we want to be able to
keep it running for a while.

This patch adds a new browser that we would compile and maintain
specifically for Mac 10.14: `deprecated-webkit-mac-10.14`. This
browser is a clone of Webkit r1443 that is the last known revision
to compile on Mac 10.14.

As we move on, we're free to modify this browser however we want,
backporting important patches.

References microsoft#5833
@aslushnikov aslushnikov mentioned this issue Mar 16, 2021
Merged
aslushnikov added a commit that referenced this issue Mar 16, 2021
@aslushnikov
devops: fork webkit into a separate browser (#5834)
e64f666 
Official WebKit no longer supports Mac 10.14. However, since
this system is still very much in use, we want to be able to
keep it running for a while.

This patch adds a new browser that we would compile and maintain
specifically for Mac 10.14: `deprecated-webkit-mac-10.14`. This
browser is a clone of Webkit r1443 that is the last known revision
to compile on Mac 10.14.

As we move on, we're free to modify this browser however we want,
backporting important patches.

References #5833
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 16, 2021
@aslushnikov
devops: start downloading webkit fork on Mac 10.14
c1fb1ea 
References microsoft#5833
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 16, 2021
@aslushnikov
devops: start downloading webkit fork on Mac 10.14
3e99ad1 
References microsoft#5833
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 16, 2021
@aslushnikov
devops: start downloading webkit fork on Mac 10.14
322edf5 
References microsoft#5833
@aslushnikov aslushnikov mentioned this issue Mar 16, 2021
Merged
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 17, 2021
@aslushnikov
devops: start downloading webkit fork on Mac 10.14
42d66bb 
References microsoft#5833
aslushnikov added a commit that referenced this issue Mar 17, 2021
@aslushnikov
devops: start downloading webkit fork on Mac 10.14 (#5837)
ae460f0 
References #5833
@aslushnikov
Copy link
Collaborator Author

Mac bots are now setup on private repo. Results are available on https://flaky.aslushnikov.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov