Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Warning, instead of error, on devtools: true #1440

Closed
arjunattam opened this issue Mar 20, 2020 · 0 comments · Fixed by #1463
Closed

[Feature] Warning, instead of error, on devtools: true #1440

arjunattam opened this issue Mar 20, 2020 · 0 comments · Fixed by #1463

Comments

@arjunattam
Copy link
Contributor

For dev environments, the devtools: true option is very valuable. Since it is Chromium-only, the current behavior is to throw an error when the option is passed for Firefox or WebKit. This means the user needs to tweak the launch args whenever the browser type is changed.

Assuming this option cannot be applied to all browsers (needless to say that would be awesome), I think Playwright should throw a warning and continue with the browser launch. That way, the same code can be used across the 3 browsers, making things a bit simpler. Possible warning text:

devtools is not supported as a launch argument in Firefox. You can launch
the devtools window manually.
@mxschmitt mxschmitt mentioned this issue Mar 21, 2020
Merged
aslushnikov pushed a commit that referenced this issue Mar 24, 2020
@mxschmitt
feat: show warning on ff & wk if devtools was given (#1463)
4b1fa2f 
Show just a warning instead of preventing the launch on Firefox and WebKit to minimize the error rate / entry barrier.

Not fully sure if `console.warn` is okay for that.

Closes #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: show warning on ff & wk if devtools was given mxschmitt/playwright
1 participant
@arjunattam