Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION]: webkit tests fails on travis #1016

Closed
hdorgeval opened this issue Feb 14, 2020 · 2 comments · Fixed by #1017
Closed

[REGRESSION]: webkit tests fails on travis #1016

hdorgeval opened this issue Feb 14, 2020 · 2 comments · Fixed by #1017

Comments

@hdorgeval
Copy link
Contributor

Context:

  • GOOD Playwright Version: [0.10.0]
  • BAD Playwright Version: [0.11.0]
  • Operating System: [Linux]
  • Extra: [Travis]

Code Snippet

// this a Jest test
test('should close webkit - playwright issue v0.11.0', async (): Promise<void> => {
    // Given
    const browser = await webkit.launch({ headless: false });
    const browserContext = await browser.newContext({ viewport: null });
    const page = await browserContext.newPage();
    await page.goto('https://google.com');

    // When
    await sleep(1000);
    const previousConnectedStatus = browser.isConnected();
    await browser.close();
    await sleep(1000);
    const afterCloseConnectedStatus = browser.isConnected();

    // Then
    expect(browser).toBeDefined();
    expect(previousConnectedStatus).toBe(true);
    expect(afterCloseConnectedStatus).toBe(false);
  });

Describe the bug

Error message, for all tests that launch a webkit browser, is:

Failed to launch browser!
    TROUBLESHOOTING: https://github.com/Microsoft/playwright/blob/master/docs/troubleshooting.md
      at onClose (node_modules/playwright-core/lib/server/processLauncher.js:139:20)
      at Interface.helper_1.helper.addEventListener (node_modules/playwright-core/lib/server/processLauncher.js:132:65)

For more details, you can look at:
travis build
repo
source test file

Thank you for your help.

aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 15, 2020
@aslushnikov
Copy link
Collaborator

Thanks! New webkit requires libvpx5 to be installed in the environment; we've updated our .travis.yml

@hdorgeval
Copy link
Contributor Author

Hi @aslushnikov , thank you very much for having solved this so fast 🥇 👍
It works now fine on my side and travis build is green.

jperl added a commit to qawolf/qawolf that referenced this issue Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants