chore: bump extract-zip dependency (#1696)

Fixes #1510
microsoft · Apr 7, 2020 · 949dc7b · 949dc7b
1 parent c6f580f
commit 949dc7b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "debug": "^4.1.0",
-    "extract-zip": "^1.6.6",
+    "extract-zip": "^2.0.0",
     "https-proxy-agent": "^3.0.0",
     "jpeg-js": "^0.3.6",
     "mime": "^2.4.4",

diff --git a/src/server/browserFetcher.ts b/src/server/browserFetcher.ts
@@ -145,7 +145,7 @@ export async function downloadBrowser(options: DownloadOptions): Promise<void> {
   const zipPath = path.join(os.tmpdir(), `playwright-download-${browser}-${platform}-${revision}.zip`);
   try {
     await downloadFile(url, zipPath, progress);
-    await extractZip(zipPath, downloadPath);
+    await extract(zipPath, {dir: downloadPath});
   } finally {
     if (await existsAsync(zipPath))
       await unlinkAsync(zipPath);
@@ -211,15 +211,6 @@ function downloadFile(url: string, destinationPath: string, progressCallback: On
   }
 }
 
-function extractZip(zipPath: string, folderPath: string): Promise<Error | null> {
-  return new Promise((fulfill, reject) => extract(zipPath, {dir: folderPath}, err => {
-    if (err)
-      reject(err);
-    else
-      fulfill();
-  }));
-}
-
 function httpRequest(url: string, method: string, response: (r: any) => void) {
   let options: any = URL.parse(url);
   options.method = method;