Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MethodLoadUnloadVerboseTraceData to reflect MethodLoadUnloadVerbose_V2 manifest #303

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Update MethodLoadUnloadVerboseTraceData to reflect MethodLoadUnloadVerbose_V2 manifest #303

merged 2 commits into from
Jul 12, 2017

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jul 12, 2017

Extends parsing of MethodLoadUnloadVerboseTraceData events to support the ReJITID property described in the MethodLoadUnloadVerbose_V2 manifest.

…oseTraceData to reflect MethodLoadUnloadVerbose_V2 manifest
@msftclas
Copy link

@hoyosjs,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@hoyosjs,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

…osoft-Windows-DotNETRuntime/Method/LoadVerbose events
@codecov-io
Copy link

codecov-io commented Jul 12, 2017

Codecov Report

Merging #303 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   24.35%   24.36%   +<.01%     
==========================================
  Files         199      199              
  Lines      112479   112487       +8     
  Branches    11228    11230       +2     
==========================================
+ Hits        27397    27402       +5     
- Misses      85055    85058       +3     
  Partials       27       27
Flag Coverage Δ
#2015 24.35% <83.33%> (ø) ⬆️
#2017 24.36% <83.33%> (ø) ⬆️
#Debug 15.81% <66.66%> (ø) ⬆️
#Release 14.89% <50%> (ø) ⬆️
Impacted Files Coverage Δ
src/TraceEvent/Parsers/ClrTraceEventParser.cs 38.46% <83.33%> (+0.02%) ⬆️
src/TraceEvent/TraceUtilities/HistoryDictionary.cs 73.78% <0%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2884d...28a88a7. Read the comment docs.

@vancem
Copy link
Contributor

vancem commented Jul 12, 2017

LGTM

@vancem vancem merged commit 0d96199 into microsoft:master Jul 12, 2017
@hoyosjs hoyosjs deleted the MethodLoadUnloadVerbose_V2_ReJITID branch July 12, 2017 16:02
vancem added a commit to vancem/perfview that referenced this pull request Dec 20, 2017
…_V2_ReJITID

Update MethodLoadUnloadVerboseTraceData to reflect MethodLoadUnloadVerbose_V2 manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants