Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "UserWarning: Unsupported Windows version (11). ONNX Runtime sup… #19845

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

enximi
Copy link
Contributor

@enximi enximi commented Mar 11, 2024

fix: "UserWarning: Unsupported Windows version (11). ONNX Runtime supports Windows 10 and above, only."

Description

Include Windows 11 in the version check. Now, you will not see the warning “Unsupported Windows version (11). ONNX Runtime supports Windows 10 and above, only.”

Motivation and Context

Warning on Windows 11: Only supports systems above Windows 10, which is somewhat strange.

@snnn
Copy link
Member

snnn commented Mar 11, 2024

I have a Windows 11, but I didn't hit this warning.

image

The OS is:

OS Name	Microsoft Windows 11 Enterprise
Version	10.0.22631 Build 22631

Which Windows version do you have?

@snnn
Copy link
Member

snnn commented Mar 13, 2024

/azp run Big Models, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, Windows ARM64 QNN CI Pipeline

@snnn
Copy link
Member

snnn commented Mar 13, 2024

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change __my_distro_var__ to __my_distro_ver__

@enximi
Copy link
Contributor Author

enximi commented Mar 14, 2024

I have changed __my_distro_var__ to __my_distro_ver__. Despite using Python 3.11, my computer outputs '11'. On a different computer, it outputs '10'. This is quite puzzling.

@snnn
Copy link
Member

snnn commented Mar 14, 2024

/azp run Big Models, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, Windows ARM64 QNN CI Pipeline

@snnn
Copy link
Member

snnn commented Mar 14, 2024

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snnn snnn merged commit 7b46b31 into microsoft:main Mar 15, 2024
61 checks passed
YUNQIUGUO pushed a commit that referenced this pull request Mar 21, 2024
#19845)

fix: "UserWarning: Unsupported Windows version (11). ONNX Runtime
supports Windows 10 and above, only."

### Description

Include Windows 11 in the version check. Now, you will not see the
warning “Unsupported Windows version (11). ONNX Runtime supports Windows
10 and above, only.”

### Motivation and Context

Warning on Windows 11: Only supports systems above Windows 10, which is
somewhat strange.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants