fix(nova-react-test-utils): improve types for WithoutFragmentRefs #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a utility
WithoutFragmentRefs
that makes sure Typescript doesn't want us to provide args that are defined onreferenceEntries
. However, the way we wrote the type impacts therender
function of a Story as well, needing us to either disabled type check there or provide not correct props. In this PR we adjust the type to beStoryObjWithoutFragmentRefs
which removes the props defined inreferenceEntries
fromargs
only, instead of all types inStoryObj
. As the type was pretty complex due to howStoryObj
handles required vs optional args and how it is able to handleargs
defined onmeta object
we also add type based tests intypes.d-test.ts
file