Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule to latest master in microsoft/main #1383

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

microsoft-golang-bot
Copy link
Collaborator

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Auto-approving.

@qmuntal
Copy link
Contributor

qmuntal commented Nov 4, 2024

Please don't resolve this conflicts until all my SymCrypt PRs are merged.

@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch from 5c9b2d6 to 5b7c726 Compare November 4, 2024 16:07
dagood
dagood previously requested changes Nov 4, 2024
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 4 times, most recently from 87a909e to 0f15d0e Compare November 15, 2024 16:07
@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch from 0f15d0e to 4f1bf64 Compare November 18, 2024 16:07
@qmuntal
Copy link
Contributor

qmuntal commented Nov 20, 2024

CI is failing due to golang/go#70463. I've already sent a fix for it: https://go-review.googlesource.com/c/go/+/630096.

karianna
karianna previously approved these changes Nov 22, 2024
@karianna karianna dismissed their stale review November 22, 2024 08:02

Incorrect review

@qmuntal qmuntal closed this Nov 22, 2024
auto-merge was automatically disabled November 22, 2024 11:52

Pull request was closed

@qmuntal qmuntal force-pushed the dev/auto-sync/microsoft/main branch from 2f65945 to ee6a6bf Compare November 22, 2024 11:52
@qmuntal qmuntal reopened this Nov 22, 2024
@qmuntal
Copy link
Contributor

qmuntal commented Nov 22, 2024

Patch conflicts resolved, now I only have to fix the tests...

@qmuntal
Copy link
Contributor

qmuntal commented Dec 9, 2024

For #1416.

@qmuntal
Copy link
Contributor

qmuntal commented Dec 12, 2024

The fixes necessary to reconcile our fork with upstream are growing to the point that the PR is hard to review. I'll be extracting some of the commits to their own PR.

@qmuntal qmuntal force-pushed the dev/auto-sync/microsoft/main branch from 7c4ee0a to 2ba8745 Compare December 16, 2024 09:37
@qmuntal qmuntal force-pushed the dev/auto-sync/microsoft/main branch from fb10acd to d2ea31c Compare December 16, 2024 12:05
@qmuntal
Copy link
Contributor

qmuntal commented Dec 16, 2024

Finally, no conflicts and tests passing 🎉.

@qmuntal qmuntal requested review from karianna, dagood and gdams December 16, 2024 13:47
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it!

@qmuntal qmuntal merged commit a650a03 into microsoft/main Dec 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants