[release/0.4] Backport fixes from v0.5.1 to 0.4 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These packages had incorrect error handling for their generated syscall bindings. The functions they were calling returned errors directly, but the binding was written such that the generated code was calling GetLastError instead. Thankfully, this did not affect the detection of whether or not an error had occurred, it only caused the value returned in the case of an error to be not the right error code. Signed-off-by: Kevin Parsons <[email protected]> (cherry picked from commit 9f0ab2c) Signed-off-by: Kevin Parsons <[email protected]>
(cherry picked from commit 0b148d1) Signed-off-by: Kevin Parsons <[email protected]>
A recent OS change altered how sparse files are represented in backup streams. This caused backuptar to no longer work with certain files. The specific behavior that changed is as follows: - Empty sparse files (size = 0), previously did not have any data or sparse block streams in the backup stream. Now, they will have a data stream with size = 0, and no sparse block streams. - Sparse files with a single allocated range (e.g. a normal file that has the sparse attribute set) previously would not show as sparse in the backup stream. Now, they will show as sparse. The old backuptar behavior assumed that if the sparse flag was set on the data stream, then there would always be a set of sparse blocks following. These changes break this assumption, and so require special handling. It is unsupported to have a data stream, marked sparse, that contains file content AND a series of sparse block streams following. As far as I can tell this is not a valid case for backup streams. This change also cleans up some code and error messages, and expands on the test coverage for backuptar. For more information on backup stream format see: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-bkup/f67950c8-d583-469a-83dd-c4ff4cedf533 Signed-off-by: Kevin Parsons <[email protected]> (cherry picked from commit 33a4801) Signed-off-by: Kevin Parsons <[email protected]>
Signed-off-by: Kyle Wojtaszek <[email protected]> (cherry picked from commit 4c72048) Signed-off-by: Kevin Parsons <[email protected]>
katiewasnothere
approved these changes
Oct 15, 2021
dcantah
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of these PRs: