functions SDDL, EA & Reparse encoding #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Sep 14, 2021
dcantah
reviewed
Sep 14, 2021
dcantah
reviewed
Sep 14, 2021
dcantah
reviewed
Sep 14, 2021
dcantah
reviewed
Sep 14, 2021
dcantah
approved these changes
Sep 17, 2021
|
@kevpar Could you please take a look? |
|
Perhaps in the future we should have a separate package concerned with encoding Windows files in a tar, and |
|
Would like to see a commit title that is clearer on what this does. I would suggest something like |
kevpar
reviewed
Nov 11, 2021
Separates out Security Descriptor (SDDL), Extended Attribute (EA) and Reparse tag encoding code into individual functions so that those functions can be reused in other code (like CimFS layer writing) Signed-off-by: Amit Barve <[email protected]>
ambarve
force-pushed
the
encode_functions
branch
from
7e9b083 to
184126a
Compare
|
@kevpar I have updated the commit message. Can you please take another look? |
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates out Security Descriptor (SDDL), Extended Attribute (EA) and Reparse tag encoding
code into individual functions so that those functions can be reused in other code (like
CimFS layer writing)
Signed-off-by: Amit Barve [email protected]