Allow guid package to be used on non-Windows GOOS targets #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterry75
approved these changes
Jan 13, 2020
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Feb 3, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Feb 5, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Feb 7, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
`golang.org/x/sys/windows.GUID` is currently only available to builds targeting `GOOS=windows` (see golang/go#36485). This change makes it so `windows` builds continue to use `golang.org/x/sys/windows.GUID`, while non-`windows` builds get a different structure that has all the same fields and methods.
|
Rebased, assuming (at least some of) those warnings are cleaned up in |
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Mar 7, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Mar 7, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Mar 7, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Mar 7, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
jingxu97
added a commit
to jingxu97/csi-proxy
that referenced
this pull request
Mar 9, 2020
enable unit test by uncommenting main in .prow.sh. Add test module in Makefile. Due to the issue related to guid package microsoft/go-winio#169 which causes errors when running unit tests on Linux, the current solution is to add some filter for the test path. Will update it after the issue is resolved.
|
What's needed to move this forward? |
|
Could someone merge this? |
|
Just wanted to ping this again |
|
@microsoft/containerplat: This already had an approving review from @jterry75, I would have thought that would meet the review requirement? Is this just a bug in the merge-management script? Edit: Hmm. I guess I can't tag Microsoft's groups like that. |
dcantah
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang.org/x/sys/windows.GUIDis currently only available to buildstargeting
GOOS=windows(see golang/go#36485). This change makes itso
windowsbuilds continue to usegolang.org/x/sys/windows.GUID,while non-
windowsbuilds get a different structure that has allthe same fields and methods.
Fixes #158.