-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for controlling legend selection and persisting in json schema #33477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
Anush2303
reviewed
Dec 16, 2024
fabricteam
reviewed
Dec 16, 2024
change/@fluentui-react-charting-779871c9-4df7-4cc5-96b6-832621cec379.json
Show resolved
Hide resolved
Anush2303
reviewed
Dec 16, 2024
packages/charts/react-charting/src/components/DeclarativeChart/DeclarativeChart.tsx
Show resolved
Hide resolved
Pull request demo site: URL |
Anush2303
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Add support to control the selected legends in declarative chart using provided json schema.
Also adding a callback to update the json schema based on user selected legends.
Added controls in UI to test this behavior.
Upcoming changes
Related Issue(s)