(web-components) Cleaned up shared styles for button and input for improved reuse and color updates #24929
Conversation
bheston
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
📊 Bundle size report🤖 This report was generated against 3757c89720f0273ed00441f11104a000fe0edc52 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f58e0ba:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3757c89720f0273ed00441f11104a000fe0edc52 (build) |
| _lightweightButtonStyles, | ||
| _neutralButtonStyles, | ||
| _outlineButtonStyles, | ||
| _stealthButtonStyles, |
There was a problem hiding this comment.
This is strange since we don't have this naming convention anywhere else in any of our codebases.
There was a problem hiding this comment.
Fair. I was under the impression that internals weren't considered part of the public API and I was just resolving the warning the API report generates. I've reverted this.
There was a problem hiding this comment.
I don't think you were wrong in doing that. It's more of what we have as a patter. I think we could talk about doing this more broadly in the future.
msft-fluent-ui-bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
bheston
force-pushed
the
shared-styles-cleanup
branch
from
6b1e1cc to
f58e0ba
Compare
…proved reuse and color updates (microsoft#24929) * Cleaned up shared styles for button and input for improved reuse and color updates * Change file * Remove underscore update on internals. * Fix lint issues
Current Behavior
Currently a few components share some common styling, but it's organized such that some attributes must be overwritten or removed if a different component
appearancedoesn't need them. This has made applying some color recipe updates that support opacity for use of mica difficult.New Behavior
Following #24771
This PR cleans up the shared styles to they are more composable and removes the need to reverse attributes that were unnecessarily set.
This update does not produce a visual difference aside from Combobox which currently is missing the focus underline treatment it should have. This PR fixes that, aside from that there are no other visual changes I found.
Anchor
Anchor HC
Button
Button HC
Inputs
Inputs HC
