-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove v2 web components and replace with visually aligned v3 alpha web components #22458
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 88f2e31:
|
@@ -1686,6 +1686,13 @@ | |||
resolved "https://registry.yarnpkg.com/@fluentui/react-icons/-/react-icons-2.0.159-beta.10.tgz#8934c05b415bbb1b46f9085c72eaf78fd7bad967" | |||
integrity sha512-Y2pDtl6ofeqGI/M/C3T6KbFy+deT1TkQ5aMO3TWN4XgAYQb5Sww56WeuX+sQNnnIXN21HIJOS6Hw1frFtCPv0w== | |||
|
|||
"@fluentui/[email protected]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why was this added ? react-theme latest is 9.0.0-rc.4
so I'd suggest we use that one, thus removing this entry to prevent dupes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hotell ideally I don't want to take the dependency on "react-theme", we'd likely prefer to just have a set of tokens, with defaults. This will go away, but we needed to ensure we had interop w/ the React Theme Provider in the demo, and this is where the tokens currently come from.
I'll look to update and drop this dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, we should spin a new package just for tokens that will be platform/rendering layer agnostic. WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving yarn.lock changes for react build team
Hi. Excited for One Microsoft :) Do we know when this will be merged? |
This is stage one of a few. We need to drop the dependency on the current react-theme package and migrate to one with just the tokens ideally. We also have some cleanup and testing to do as the initial work provided here is an initial "stage" for the release branch. We don't have a firm date yet, but hopefully we can get a beta out soon! |
Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code. |
Current Behavior
This PR updates the web components package to remove existing components and add initial implementations of Fluent UI token and visually aligned implementations. This PR is the initial commit for the v3 release branch. A big win for One Microsoft! There is still work to do here, including updating to new templates from FAST Foundation, and updating to leverage FAST Element 2.0 - but this starts the process of migrating to components which implement the current Fluent UI specs and design tokens.
Fixes #
Fixes issues with visual alignment :)
View the components here