feat(TextArea): Add autoResize #14860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
Fluent UI react-northstar (v0)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b93e4bb:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
assuncaocharles
commented
Sep 2, 2020
| @@ -44,9 +45,16 @@ export interface TextAreaProps extends UIComponentProps, ChildrenComponentProps | |||
|
|
|||
| /** A textarea can take the width of its container. */ | |||
| fluid?: boolean; | |||
|
|
|||
| /** A textarea can be set to automatically adjust the height */ | |||
| autoAdjustHeight?: boolean; | |||
There was a problem hiding this comment.
I called it autoAdjustHeight to be similar to Fabric and it was also as the user named it when requiring it.... But I wonder if autoResize wouldn't be a better name
There was a problem hiding this comment.
I would vote for autoResize it's what I would search for if I need behavior like this.
assuncaocharles
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
assuncaocharles
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 12e72defeec4e1c2a6c7326c9cef670f6c2b2a55 (build) |
pompomon
reviewed
Sep 3, 2020
packages/fluentui/react-northstar/src/themes/teams/components/TextArea/textAreaStyles.ts
Outdated
Show resolved
Hide resolved
pompomon
reviewed
Sep 3, 2020
packages/fluentui/react-northstar/src/themes/teams/components/TextArea/textAreaStyles.ts
Outdated
Show resolved
Hide resolved
pompomon
reviewed
Sep 3, 2020
pompomon
approved these changes
Sep 3, 2020
|
Hello @assuncaocharles! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
layershifter
reviewed
Sep 3, 2020
| inputRef.current.style.height = '0'; | ||
| inputRef.current.style.height = `${inputRef.current?.scrollHeight}px`; | ||
| } | ||
| }, [inputRef.current?.scrollHeight, autoResize]); |
There was a problem hiding this comment.
During the first render inputRef.current.scrollHeight will be null. In general it's incorrect to use such things as effect dependencies
layershifter
reviewed
Sep 3, 2020
assuncaocharles
changed the title
|
assuncaocharles
added a commit
to assuncaocharles/fluentui
that referenced
this pull request
Sep 3, 2020
This reverts commit cf13453.
2 tasks
assuncaocharles
added a commit
that referenced
this pull request
Sep 3, 2020
2 tasks
hutchcodes
pushed a commit
to hutchcodes/fluentui
that referenced
this pull request
Sep 10, 2020
#### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes This PR adds the ability for `TextArea` to auto adjust the height based in the content  #### Focus areas to test (optional)
hutchcodes
pushed a commit
to hutchcodes/fluentui
that referenced
this pull request
Sep 10, 2020
…osoft#14878) This reverts commit cf13453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds the ability for
TextAreato auto adjust the height based in the contentFocus areas to test
(optional)