Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast-element: Fix parameter name in a volatile decorator JSDoc #7054

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

fast-element: Fix parameter name in a volatile decorator JSDoc #7054

wants to merge 9 commits into from

Conversation

doguabaris
Copy link
Contributor

Pull Request

📖 Description

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

doguabaris and others added 8 commits December 6, 2024 12:30
@doguabaris
fast-element: Simplify fromView condition in attributes
db0a2a8 
Replace the ternary operator with a direct negation in the fromView
method. This change enhances code readability and ensures consistent
handling of null, undefined, false, and zero values.
@doguabaris
fast-element: Update parameter name in setValue method
0a21092 
Renamed the `value` parameter to `newValue` in the `setValue` method of
the `attributes.ts` file.
@doguabaris
fast-element: Simplify conditional checks in element-controller
8f0d498 
Replaced explicit boolean comparisons with direct truthy and falsy
checks in the `connectBehaviors` and `disconnectBehaviors` methods.
@doguabaris
docs(fast-element): improve JSDoc for AttributeDefinition setValue me…
fdf26fd 
…thod

- Added a detailed description for the newValue parameter in the setValue method.
- Ensures better clarity and documentation for the method's functionality.
@janechu
Merge branch 'master' into simplify-conditional-checks
a75c090
@doguabaris
Restore explicit boolean checks in element-controller methods
9fb4760
@janechu
Merge branch 'master' into simplify-conditional-checks
8da1db4
@doguabaris
fast-element: Fix parameter name in a volatile decorator JSDoc
79bbaee 
- Corrected parameter name in JSDoc for the `volatile` decorator.
- Replaced `@param name` with `@param descriptor` for accuracy.
@doguabaris doguabaris marked this pull request as draft December 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt Awaiting requested review from chrisdholt chrisdholt is a code owner

@janechu janechu Awaiting requested review from janechu janechu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doguabaris @janechu