Update to the docs content to be @microsoft/fast-element specific
#6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @bhavyakaria for identifying and providing a PR.
git add .
eljefe223
reviewed
Jun 3, 2024
eljefe223
reviewed
Jun 3, 2024
sites/website/src/docs/advanced/working-with-custom-elements.md
Outdated
Show resolved
Hide resolved
eljefe223
reviewed
Jun 3, 2024
eljefe223
approved these changes
Jun 3, 2024
chrisdholt
approved these changes
Jun 3, 2024
janechu
added a commit
that referenced
this pull request
Jun 10, 2024
…6972) # Pull Request ## 📖 Description This update to the docs: - Re-aligns docs around `@microsoft/fast-element` - Adds more docs around the `html`, `css` and `FASTElement` exports ## 👩💻 Reviewer Notes There are 3 `TODO` marked documents that require separate PRs and reviews: - DI (Dependency Injection) - Migration (from `@microsoft/fast-element` v1 to v2) there may not be any breaking changes but there might be some suggestions for users looking to update their package - Component library - with #6955 we are looking to assist the community in the creation of packages built on the `@microsoft/fast-element` package, this should provide some best practices and guidance on doing this. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://github.com/microsoft/fast/blob/master/CODE_OF_CONDUCT.md#our-standards) for this project. ## ⏭ Next Steps - Fill in the `TODO` docs in separate PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This update to the docs:
@microsoft/fast-elementhtml,cssandFASTElementexports👩💻 Reviewer Notes
There are 3
TODOmarked documents that require separate PRs and reviews:@microsoft/fast-elementv1 to v2) there may not be any breaking changes but there might be some suggestions for users looking to update their package@microsoft/fast-elementpackage, this should provide some best practices and guidance on doing this.✅ Checklist
General
$ yarn change⏭ Next Steps
TODOdocs in separate PRs