normalize storybook fixtures #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
chrisdholt,
nicholasrice and
janechu
as code owners
radium-v
changed the title
radium-v
force-pushed
the
users/jokreitl/normalize-storybook-fixtures
branch
from
28b74de to
226f227
Compare
radium-v
commented
Aug 25, 2022
packages/web-components/fast-foundation/src/flipper/stories/flipper.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/fast-foundation/src/tooltip/stories/tooltip.stories.ts
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,13 @@ | |||
| { | |||
| "extends": ["@microsoft/eslint-config-fast-dna", "prettier"], | |||
| "rules": { | |||
| "import/extensions": [ | |||
There was a problem hiding this comment.
Is this to enforce extensions in TypeScript src files? If so I don't think it's necessary. ModuleResolution Node16 will throw compile errors if extensions don't exist.
There was a problem hiding this comment.
This was mistakenly added to this PR - it was needed during the playwright test file conversions.
change/@microsoft-fast-foundation-6f10b9c9-3154-4b85-a95c-f22a452e7d7a.json
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Aug 25, 2022
chrisdholt
approved these changes
Aug 25, 2022
EisenbergEffect
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
This is a massive accomplishment. Thanks for putting this together @radium-v. My review was pretty high-level so if there are errors in the details, I probably didn't catch them. However, from file to file things look consistent and an improvement from before. Very glad to see this coming together.
radium-v
force-pushed
the
users/jokreitl/normalize-storybook-fixtures
branch
3 times, most recently
from
146fbc7 to
04b3814
Compare
radium-v
force-pushed
the
users/jokreitl/normalize-storybook-fixtures
branch
from
04b3814 to
aa20826
Compare
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* add storybook types and renderComponent helper * add ES2017.Object lib to tsconfig * update eslintrc * add hidden debug story * move accordion types to options module * move anchor types to options module * move anchored-region types to options module * move button types to options module * move horizontal-scroll types to options module * move picker types to options module * move slider types to options module * normalize accordion stories * normalize accordion-item stories * normalize anchor stories * normalize anchored-region stories * normalize avatar stories * normalize badge stories * normalize breadcrumb stories * normalize breadcrumb-item stories * normalize button stories * normalize calendar stories * normalize card stories * normalize checkbox stories * normalize combobox stories * normalize data-grid, data-grid-row, and data-grid-cell stories * normalize dialog stories * normalize disclosure stories * normalize divider stories * normalize flipper stories * normalize horizontal-scroll stories * normalize listbox stories * normalize listbox-option stories * normalize menu stories * normalize menu-item stories * normalize number-field stories * normalize picker stories * normalize progress stories * normalize progress and progress-ring stories * normalize radio stories * normalize radio-group stories * normalize search stories * normalize select stories * normalize skeleton stories * normalize slider stories * normalize slider-label stories * normalize switch stories * normalize tab stories * normalize tab-panel stories * normalize tabs stories * normalize text-area stories * normalize text-field stories * normalize toolbar stories * normalize tooltip stories * normalize tree-item stories * normalize tree-view stories * update api-report and READMEs * Change files * patch flipper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Normalizes all storybook stories by updating types, implementing a
renderComponenthelper function, and adding conventions for the optional, story-specificstoryContentandstoryItemsargs.👩💻 Reviewer Notes
I moved any types and enum-style consts to the separate
*options.tsfile for each component, which helps isolate those simple values and types for both Storybook and Playwright usage. This will be more important on the Playwright side, since PW's TypeScript handling runs into errors when trying to load any component modules in its node source.📑 Test Plan
All tests should pass as expected.
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps
This PR is split from the work in #6189.