fix: incorrect z-index in fast-menu slot='submenu' #5452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
When using a menu next to another menu, submenus will appear under menu items of the next menu.
π« Issues
#5417
π©βπ» Reviewer Notes
This is the least obtrusive way to get flyout menus to go over other elements. This will fix both the issue of a menu next to another menu as well as submenus going under an element next to it that has
position: relative
orposition: absolute
. Even if that element doesn't have a z-index property. Developers can still manage z-index on the fast-menu-item as in the example that I added to the fixture. They could also add z-index to the fast-menu but that becomes trickier if they are using menus side-by-side.π Test Plan
Not really testable in Jest. Added a working example in the fixtures.
β Checklist
General
$ yarn change
Component-specific
β Next Steps