Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect z-index in fast-menu slot='submenu' #5452

Merged
merged 4 commits into from
Dec 10, 2021

Conversation

robarbms
Copy link
Contributor

@robarbms robarbms commented Dec 9, 2021

Pull Request

πŸ“– Description

When using a menu next to another menu, submenus will appear under menu items of the next menu.

🎫 Issues

#5417

πŸ‘©β€πŸ’» Reviewer Notes

This is the least obtrusive way to get flyout menus to go over other elements. This will fix both the issue of a menu next to another menu as well as submenus going under an element next to it that has position: relative or position: absolute. Even if that element doesn't have a z-index property. Developers can still manage z-index on the fast-menu-item as in the example that I added to the fixture. They could also add z-index to the fast-menu but that becomes trickier if they are using menus side-by-side.

πŸ“‘ Test Plan

Not really testable in Jest. Added a working example in the fixtures.

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@robarbms robarbms self-assigned this Dec 9, 2021
@robarbms robarbms linked an issue Dec 9, 2021 that may be closed by this pull request
@robarbms robarbms merged commit 66dca80 into master Dec 10, 2021
@robarbms robarbms deleted the users/robarb/menu-z-index branch December 10, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Incorrect z-index in fast-menu slot="submenu"
3 participants