Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#4684] ESLint issues in botframework-config #4815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: [#4684] ESLint issues in botframework-config #4815

wants to merge 2 commits into from

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botframework-config project.

Specific Changes

  • Removed 'botframework-config/eslint.config.cjs' file as it contained only the 'only-warn' plugin which was no longer needed.
  • Applied the auto-fix flag for all the issues (spacing and trailing commas).

Testing

The following images show the number of issues fixed in the library.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 11, 2024 11:26
@coveralls
Copy link

coveralls commented Dec 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12275395925

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%
Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20513
Relevant Lines: 23091
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceciliaavila @coveralls