Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-lg #4803

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botbuilder-lg project.

Specific Changes

  • Removed the 'only-warnings' plugin from 'botbuilder-lg/eslint.config.cjs' file and the related dependency.
  • Applied the auto fix flag for most issues (spacing, trailing commas, indentation, and removing unnecessary eslint exceptions).
  • Applied manual fixes for new rules like 'no-require-imports'.

Testing

The following images show the number of issues fixed in the library and the tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner November 29, 2024 12:06
@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12084447514

Details

  • 122 of 161 (75.78%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 84.686%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-lg/src/evaluator.ts 73 74 98.65%
libraries/botbuilder-lg/src/extractor.ts 1 2 50.0%
libraries/botbuilder-lg/src/expander.ts 44 81 54.32%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/customizedMemory.ts 1 96.77%
libraries/botbuilder-lg/src/expander.ts 2 72.57%
Totals Coverage Status
Change from base Build 12051547941: -0.005%
Covered Lines: 20528
Relevant Lines: 23085

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 64a10b1 into main Dec 9, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-lg branch December 9, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants