Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#6813][#6798] Not able to create instance of BlobsTranscriptStore using TokenCredential instead of connectionString and containerName #4720

Merged

Conversation

JhontSouth
Copy link
Collaborator

Fixes #4715

Description

This PR allows the use of Token Credentials to authenticate and create an instance of BlobsTranscriptStore.

Specific Changes

  • Added parameters blobServiceUri and tokenCredential in BlobsTranscriptStore constructors.
  • Added constructor validations in unit tests.

Testing

The following images show the bot working and saving transcripts using BlobsTranscriptStore instantiated with token credentials.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner July 26, 2024 16:56
@coveralls
Copy link

coveralls commented Jul 26, 2024

Pull Request Test Coverage Report for Build 10114846031

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 11 14 78.57%
Totals Coverage Status
Change from base Build 10112673859: -0.02%
Covered Lines: 20435
Relevant Lines: 22913

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 543f70c into main Jul 31, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/blobtranscriptstore-token-credential branch July 31, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants