Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add Recognizers-Text packages to botbuilder-stdlib #4660

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented May 7, 2024

#minor

Related PR: #4661

Description

This PR adds https://github.com/microsoft/Recognizers-Text into botbuilder-stdlib library, so it's easier to update vulnerable dependencies without introducing breaking changes.
botbuilder-stdlib is an internal library that contains helper functions which the rest of botbuilder libraries use. Therefore, we included the Recognizers-Text packages under the vendors folder, so botbuilder libraries can consume them.

Specific Changes

  • Updated libraries/botbuilder-repo-utils/src/workspace.ts to search workspaces, taking into account .gitignore and the location where the command is run. Otherwise, it will cause unwanted behaviors where nested dependencies inside node_modules were considered as a workspace.
  • Added all Recognizers-Text packages into the vendors folder.
    • All dependencies have been moved to botbuilder-stdlib package.json, so they are installed properly.
    • Updated all types references to match each Recognizers-Text package inside botbuilder-stdlib.

Testing

The following image shows the bot working with the new Recognizers-Text packages inside BotBuilder.
imagen

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8985604338

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 8971038880: 0.0%
Covered Lines: 20426
Relevant Lines: 22901

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants