Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use jest-circus runner to improve beforeAll/beforeEach failure behavior #12

Merged
merged 4 commits into from
May 23, 2019
Merged

use jest-circus runner to improve beforeAll/beforeEach failure behavior #12

merged 4 commits into from
May 23, 2019

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented May 22, 2019

Description of changes

Updates jest.config.js to recommend use of the jest-circus runner to enable tests to early-exit when beforeAll/beforeEach methods fail, per jestjs/jest#2713

Pull request checklist

  • If this PR addresses an existing issue, it is linked: Fixes #0000
  • yarn test passes in all affected samples
  • Added any applicable tests

@dbjorge dbjorge requested a review from a team May 22, 2019 03:09
karanbirsingh
karanbirsingh previously approved these changes May 22, 2019
View reviewed changes
@dbjorge dbjorge mentioned this pull request May 23, 2019
Merged
3 tasks
Shobhit1
Shobhit1 approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@Shobhit1 Shobhit1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a nit. Can be take care later as well.

typescript-selenium-webdriver/tests/index.test.ts Show resolved Hide resolved
flyingUnderTheRadar
flyingUnderTheRadar approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@flyingUnderTheRadar flyingUnderTheRadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbjorge dbjorge merged commit 531fa0a into microsoft:master May 23, 2019
@dbjorge dbjorge deleted the use-jest-circus branch May 23, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyingUnderTheRadar flyingUnderTheRadar flyingUnderTheRadar approved these changes

@waabid waabid waabid approved these changes

@Shobhit1 Shobhit1 Shobhit1 approved these changes

@karanbirsingh karanbirsingh karanbirsingh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbjorge @Shobhit1 @karanbirsingh @waabid @flyingUnderTheRadar