Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local "npm run test" speed from 2:28 to 1:11 #285

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Mar 4, 2019

Pull request checklist

  • (n/a) Addresses an existing issue
  • (n/a) Added relevant unit test for your changes. (npm run test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (npm run precheckin)
  • (n/a) Added screenshots/GIFs for UI changes.

Description of changes

A huge amount of npm run test's time was being spent in console output that we don't need. Removing the verbose output per jestjs/jest#6694 (comment) cuts the total runtime on my dev box by more than half.

Notes for reviewers

I also experimented with replacing the default reporter, per the same suggestion, but found that this had a negligible impact after the verbose change.

@dbjorge dbjorge requested a review from a team March 4, 2019 23:13
@dbjorge dbjorge added the pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay. label Mar 4, 2019
@msft-github-bot
Copy link
Collaborator

Hello @dbjorge!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

@msft-github-bot msft-github-bot merged commit c5d2465 into master Mar 4, 2019
@msft-github-bot msft-github-bot deleted the users/dbjorge/double-speed-of-unit-tests branch March 4, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants