-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bug 1159105 in samples used by accessibility test team #389
Merged
guimafelipe
merged 8 commits into
microsoft:main
from
guimafelipe:implementing-heading-level
Jul 22, 2021
Merged
Fixing bug 1159105 in samples used by accessibility test team #389
guimafelipe
merged 8 commits into
microsoft:main
from
guimafelipe:implementing-heading-level
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamBent
approved these changes
Jul 19, 2021
This is an API change so the samples repo needs to build against the updated SDK version. Until the SDK version is updated, build failures are expected. (This needs .NET 6.0 Preview 7 or later.) |
ayushverma-ms
approved these changes
Jul 22, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #388.
Description
Narrator could not read the Heading Level of headings in WPF. The new PR in WPF implements this functionality.
Customer Impact
Customers will now be able to know the heading level of the text.
Regression
No. This sample is used for Accessibility testing and never fully supported Narrator.
Testing
This sample was testes with narrator and Accessibility Insights.