Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug 1159105 in samples used by accessibility test team #389

Merged
merged 8 commits into from
Jul 22, 2021

Conversation

guimafelipe
Copy link
Contributor

Fixes issue #388.

Description

Narrator could not read the Heading Level of headings in WPF. The new PR in WPF implements this functionality.

Customer Impact

Customers will now be able to know the heading level of the text.

Regression

No. This sample is used for Accessibility testing and never fully supported Narrator.

Testing

This sample was testes with narrator and Accessibility Insights.

@guimafelipe guimafelipe requested a review from a team July 19, 2021 14:27
@ryalanms
Copy link
Member

ryalanms commented Jul 20, 2021

This is an API change so the samples repo needs to build against the updated SDK version. Until the SDK version is updated, build failures are expected. (This needs .NET 6.0 Preview 7 or later.)

@ryalanms
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryalanms ryalanms changed the base branch from net60 to main July 22, 2021 17:08
@ryalanms
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guimafelipe guimafelipe merged commit c8caabc into microsoft:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants