Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze empty arrays #58240

Closed
wants to merge 1 commit into from
Closed

Freeze empty arrays #58240

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Member

#55755 but just the arrays

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 18, 2024
@jakebailey
Copy link
Member Author

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 18, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test ✅ Started 👀 Results

@jakebailey jakebailey mentioned this pull request Apr 18, 2024
Merged
@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 297,021k (± 0.01%) 297,056k (± 0.01%) +35k (+ 0.01%) 297,030k 297,097k p=0.045 n=6
Parse Time 4.04s (± 0.24%) 4.03s (± 0.26%) ~ 4.02s 4.05s p=0.176 n=6
Bind Time 1.21s (± 0.62%) 1.21s (± 0.45%) ~ 1.21s 1.22s p=0.476 n=6
Check Time 12.14s (± 0.35%) 12.13s (± 0.33%) ~ 12.10s 12.20s p=0.872 n=6
Emit Time 10.49s (± 0.32%) 10.50s (± 0.24%) ~ 10.48s 10.54s p=0.327 n=6
Total Time 27.88s (± 0.11%) 27.89s (± 0.16%) ~ 27.83s 27.94s p=0.936 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 194,172k (± 0.97%) 193,028k (± 0.95%) ~ 191,816k 195,452k p=0.810 n=6
Parse Time 1.64s (± 1.00%) 1.64s (± 1.46%) ~ 1.60s 1.66s p=0.807 n=6
Bind Time 0.86s (± 0.97%) 0.87s (± 0.97%) ~ 0.86s 0.88s p=1.000 n=6
Check Time 11.31s (± 0.24%) 11.37s (± 0.37%) +0.06s (+ 0.50%) 11.29s 11.41s p=0.036 n=6
Emit Time 3.15s (± 0.39%) 3.15s (± 0.40%) ~ 3.13s 3.17s p=0.652 n=6
Total Time 16.96s (± 0.17%) 17.02s (± 0.31%) ~ 16.93s 17.07s p=0.077 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,750,941k (± 0.00%) 1,751,070k (± 0.00%) +129k (+ 0.01%) 1,750,981k 1,751,133k p=0.005 n=6
Parse Time 9.91s (± 0.28%) 9.88s (± 0.48%) ~ 9.82s 9.94s p=0.470 n=6
Bind Time 3.35s (± 0.38%) 3.34s (± 0.77%) ~ 3.30s 3.38s p=0.459 n=6
Check Time 82.09s (± 0.53%) 84.44s (± 0.61%) +2.35s (+ 2.86%) 83.76s 84.87s p=0.005 n=6
Emit Time 0.20s (± 2.02%) 0.20s (± 4.08%) ~ 0.20s 0.22s p=0.527 n=6
Total Time 95.55s (± 0.47%) 97.88s (± 0.52%) +2.33s (+ 2.44%) 97.17s 98.30s p=0.005 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,308,166k (± 0.02%) 2,308,361k (± 0.03%) ~ 2,307,423k 2,309,162k p=0.689 n=6
Parse Time 6.00s (± 0.71%) 6.03s (± 0.34%) ~ 6.00s 6.06s p=0.108 n=6
Bind Time 2.22s (± 0.97%) 2.24s (± 0.96%) ~ 2.20s 2.26s p=0.291 n=6
Check Time 39.83s (± 0.29%) 39.99s (± 0.30%) +0.16s (+ 0.39%) 39.84s 40.17s p=0.045 n=6
Emit Time 3.09s (± 3.03%) 3.15s (± 1.99%) ~ 3.05s 3.23s p=0.298 n=6
Total Time 51.19s (± 0.23%) 51.43s (± 0.21%) +0.24s (+ 0.47%) 51.32s 51.60s p=0.005 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used 2,381,496k (± 0.01%) 2,382,275k (± 0.02%) +779k (+ 0.03%) 2,381,812k 2,382,839k p=0.008 n=6
Parse Time 7.66s (± 0.85%) 7.62s (± 0.56%) ~ 7.56s 7.68s p=0.173 n=6
Bind Time 2.54s (± 3.67%) 2.62s (± 4.96%) ~ 2.45s 2.75s p=0.297 n=6
Check Time 49.66s (± 0.45%) 49.82s (± 0.30%) ~ 49.61s 49.97s p=0.173 n=6
Emit Time 3.85s (± 2.26%) 3.88s (± 2.74%) ~ 3.70s 3.99s p=0.810 n=6
Total Time 63.73s (± 0.24%) 63.95s (± 0.28%) ~ 63.74s 64.21s p=0.093 n=6
self-compiler - node (v18.15.0, x64)
Memory used 419,442k (± 0.01%) 419,542k (± 0.01%) +100k (+ 0.02%) 419,496k 419,584k p=0.005 n=6
Parse Time 4.18s (± 0.56%) 4.22s (± 0.29%) +0.03s (+ 0.80%) 4.20s 4.23s p=0.018 n=6
Bind Time 1.60s (± 1.79%) 1.59s (± 1.52%) ~ 1.57s 1.63s p=0.463 n=6
Check Time 22.32s (± 0.47%) 22.55s (± 0.29%) +0.22s (+ 1.01%) 22.47s 22.63s p=0.005 n=6
Emit Time 1.71s (± 1.15%) 1.72s (± 1.84%) ~ 1.66s 1.74s p=0.459 n=6
Total Time 29.82s (± 0.45%) 30.07s (± 0.22%) +0.25s (+ 0.84%) 29.99s 30.15s p=0.005 n=6
ts-pre-modules - node (v18.15.0, x64)
Memory used 369,022k (± 0.02%) 369,109k (± 0.02%) ~ 369,033k 369,207k p=0.066 n=6
Parse Time 2.96s (± 1.58%) 2.93s (± 0.35%) ~ 2.92s 2.95s p=0.288 n=6
Bind Time 1.59s (± 0.62%) 1.62s (± 1.22%) +0.02s (+ 1.47%) 1.59s 1.63s p=0.048 n=6
Check Time 15.69s (± 0.33%) 15.84s (± 0.43%) +0.15s (+ 0.98%) 15.75s 15.95s p=0.006 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.24s (± 0.33%) 20.39s (± 0.34%) +0.15s (+ 0.75%) 20.32s 20.52s p=0.013 n=6
vscode - node (v18.15.0, x64)
Memory used 2,917,437k (± 0.00%) 2,917,527k (± 0.00%) +90k (+ 0.00%) 2,917,481k 2,917,575k p=0.008 n=6
Parse Time 13.37s (± 0.23%) 13.37s (± 0.20%) ~ 13.34s 13.42s p=0.686 n=6
Bind Time 4.07s (± 0.24%) 4.09s (± 0.25%) +0.02s (+ 0.37%) 4.07s 4.10s p=0.042 n=6
Check Time 72.76s (± 0.65%) 73.45s (± 0.21%) ~ 73.24s 73.68s p=0.065 n=6
Emit Time 20.14s (± 8.35%) 19.62s (± 0.57%) ~ 19.46s 19.78s p=0.230 n=6
Total Time 110.34s (± 1.53%) 110.52s (± 0.09%) ~ 110.41s 110.69s p=0.378 n=6
webpack - node (v18.15.0, x64)
Memory used 409,437k (± 0.01%) 409,504k (± 0.02%) ~ 409,449k 409,627k p=0.066 n=6
Parse Time 3.91s (± 0.77%) 3.95s (± 0.86%) ~ 3.90s 3.99s p=0.222 n=6
Bind Time 1.65s (± 1.13%) 1.65s (± 0.83%) ~ 1.63s 1.67s p=0.934 n=6
Check Time 16.93s (± 0.23%) 17.06s (± 0.21%) +0.14s (+ 0.81%) 17.02s 17.11s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.49s (± 0.19%) 22.66s (± 0.16%) +0.17s (+ 0.75%) 22.63s 22.73s p=0.005 n=6
xstate-main - node (v18.15.0, x64)
Memory used 458,989k (± 0.01%) 459,052k (± 0.02%) ~ 458,966k 459,208k p=0.173 n=6
Parse Time 2.69s (± 0.68%) 2.69s (± 0.76%) ~ 2.65s 2.70s p=0.934 n=6
Bind Time 0.98s (± 0.64%) 0.98s (± 0.56%) ~ 0.98s 0.99s p=0.201 n=6
Check Time 15.34s (± 0.23%) 15.47s (± 0.24%) +0.13s (+ 0.87%) 15.41s 15.51s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 19.01s (± 0.21%) 19.15s (± 0.21%) +0.14s (+ 0.72%) 19.10s 19.20s p=0.005 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,342ms (± 0.54%) 2,340ms (± 0.38%) ~ 2,330ms 2,355ms p=0.469 n=6
Req 2 - geterr 5,165ms (± 2.38%) 5,156ms (± 0.34%) ~ 5,138ms 5,183ms p=0.378 n=6
Req 3 - references 287ms (± 0.42%) 286ms (± 0.88%) ~ 281ms 288ms p=1.000 n=6
Req 4 - navto 227ms (± 0.81%) 227ms (± 0.46%) ~ 226ms 228ms p=1.000 n=6
Req 5 - completionInfo count 1,357 (± 0.00%) 1,357 (± 0.00%) ~ 1,357 1,357 p=1.000 n=6
Req 5 - completionInfo 84ms (±10.45%) 88ms (± 7.56%) ~ 77ms 92ms p=0.357 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,491ms (± 0.87%) 2,504ms (± 1.27%) ~ 2,462ms 2,541ms p=0.378 n=6
Req 2 - geterr 3,898ms (± 2.19%) 3,894ms (± 2.00%) ~ 3,839ms 3,996ms p=0.378 n=6
Req 3 - references 303ms (± 1.94%) 297ms (± 0.94%) ~ 292ms 300ms p=0.157 n=6
Req 4 - navto 227ms (± 0.18%) 228ms (± 2.52%) ~ 225ms 240ms p=0.121 n=6
Req 5 - completionInfo count 1,519 (± 0.00%) 1,519 (± 0.00%) ~ 1,519 1,519 p=1.000 n=6
Req 5 - completionInfo 80ms (± 5.60%) 71ms (± 2.29%) 🟩-9ms (-11.20%) 68ms 72ms p=0.003 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,655ms (± 0.42%) 2,654ms (± 0.17%) ~ 2,648ms 2,661ms p=0.575 n=6
Req 2 - geterr 1,481ms (± 0.62%) 1,478ms (± 0.47%) ~ 1,469ms 1,490ms p=0.575 n=6
Req 3 - references 141ms (± 6.64%) 132ms (± 4.12%) ~ 129ms 143ms p=0.252 n=6
Req 4 - navto 347ms (± 0.50%) 359ms (± 1.37%) +12ms (+ 3.31%) 354ms 366ms p=0.005 n=6
Req 5 - completionInfo count 2,079 (± 0.00%) 2,079 (± 0.00%) ~ 2,079 2,079 p=1.000 n=6
Req 5 - completionInfo 297ms (± 0.71%) 293ms (± 3.09%) ~ 287ms 306ms p=0.376 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 155.05ms (± 0.17%) 155.11ms (± 0.15%) +0.06ms (+ 0.04%) 154.10ms 157.83ms p=0.001 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 227.69ms (± 0.14%) 227.47ms (± 0.17%) -0.21ms (- 0.09%) 225.81ms 234.31ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 223.65ms (± 0.15%) 223.65ms (± 0.17%) ~ 222.29ms 229.95ms p=0.987 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 223.44ms (± 0.16%) 223.47ms (± 0.18%) ~ 222.12ms 229.73ms p=0.692 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey jakebailey closed this Jul 24, 2024
@jakebailey jakebailey deleted the freeze-empty branch July 24, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @typescript-bot