Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export path patterns with .d.ts target extensions in AutoImportProvider #55815

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

andrewbranch
Copy link
Member

Fixes #53116 (a corner case of the 5.2 feature not working)

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 21, 2023
@@ -2212,7 +2212,11 @@ function loadEntrypointsFromExportMap(
scope.packageDirectory,
extensionsToExtensionsArray(extensions),
/*excludes*/ undefined,
[changeAnyExtension(target.replace("*", "**/*"), getDeclarationEmitExtensionForPath(target))],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was turning *.d.ts into *.d.d.ts

Comment on lines +2217 to +2218
? target.replace("*", "**/*")
: changeAnyExtension(target.replace("*", "**/*"), getDeclarationEmitExtensionForPath(target)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait for CodeQL to complain about these

src/compiler/moduleNameResolver.ts Dismissed Show dismissed Hide dismissed
src/compiler/moduleNameResolver.ts Dismissed Show dismissed Hide dismissed
@andrewbranch andrewbranch merged commit 5b7b011 into main Sep 21, 2023
19 checks passed
@andrewbranch andrewbranch deleted the 53116 branch September 21, 2023 22:03
snovader pushed a commit to mestro-se/TypeScript that referenced this pull request Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer auto-imports for all files in package.json exports wildcard directories
4 participants