Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(40004): Missing Compiler API predicate function: isNamedTupleMember #40005

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #40004

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 11, 2020
@DanielRosenwasser
Copy link
Member

@rbuckton should this land in 4.0?

@rbuckton
Copy link
Member

It wouldn't hurt anything to add it and it would be helpful for API consumers

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0 and LKG

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 12, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at fa1ed85. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0 and LKG

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 12, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at fa1ed85. You can monitor the build here.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 12, 2020
Component commits:
fa1ed85 feat(40004): make isNamedTupleMember public
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #40015 for you.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 12, 2020
Component commits:
fa1ed85 feat(40004): make isNamedTupleMember public
DanielRosenwasser pushed a commit that referenced this pull request Aug 12, 2020
…e-4.0 (#40015)

* Cherry-pick PR #40005 into release-4.0

Component commits:
fa1ed85 feat(40004): make isNamedTupleMember public

* Update LKG

Co-authored-by: Alexander T <[email protected]>
Co-authored-by: typescript-bot <[email protected]>
@DanielRosenwasser DanielRosenwasser merged commit 610fa28 into microsoft:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Compiler API predicate function: isNamedTupleMember
4 participants