Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Block new docker-cimprov installations #1557

Closed
wants to merge 9 commits into from
Closed

Block new docker-cimprov installations #1557

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c970bc1
Fix malformed docker-cimprov
sarahpeiffer Oct 26, 2023
c721211
update docker-cimprov to 1.0.0-43
sarahpeiffer Nov 6, 2023
cb3f36a
resolve merge conflicts
sarahpeiffer Nov 6, 2023
7f0258d
Merge branch 'master' of https://github.com/sarahpeiffer/OMS-Agent-fo…
sarahpeiffer Nov 6, 2023
422b3dc
update docker-cimprov to 1.0.0-44
sarahpeiffer Feb 5, 2024
8c0cd49
Merge branch 'master' into master
sarahpeiffer Feb 5, 2024
64c24ae
remove old docker
sarahpeiffer Feb 5, 2024
caf820a
block new installations
sarahpeiffer Feb 28, 2024
b37c163
Merge pull request #3 from microsoft/master
sarahpeiffer Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions installer/bundle/bundle_skel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,10 +1456,8 @@ case "$installMode" in
OSS_BUNDLE=`basename $i -oss-test.sh`
[ ! -f oss-kits/${OSS_BUNDLE}-cimprov-*.sh ] && continue

if [ "$OSS_BUNDLE" = "docker" ] && [ "$skipDockerProviderInstall" = "true" ]; then
echo "$OSS_BUNDLE provider package installation skipped since --skip-docker-provider-install flag is set. \
If you are installing over an existing omsagent install and wish to remove the docker provider, \
you should first purge the existing installation and then install using the --skip-docker-provider-install flag."
# New installations of the docker-cimprov package are no longer supported
Copy link
Contributor

@ganga1980 ganga1980 Mar 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the option --skip-docker-provider-install being ignored for the new installations with this change, we should remove this option from supported install command options

if [ "$OSS_BUNDLE" = "docker" ]; then
continue
fi

Expand Down
Loading