Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CameraSettingsManager to the MRTK XR Rig #11684

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

shaynie
Copy link
Collaborator

@shaynie shaynie commented Jul 6, 2023

Add the 'Unknown' display type and default to 'Unknown' when there is no running XRDisplaySubsystem running. Add CameraSettingsManager to the MRTK XR Rig prefab

Overview

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

… no running XRDisplaySubsystem running. Add CameraSettingsManager to the MRTK XR Rig prefab
Copy link
Member

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this change?

com.microsoft.mrtk.core/Utilities/DisplayType.cs Outdated Show resolved Hide resolved
@shaynie shaynie merged commit bda1893 into microsoft:mrtk3 Jul 6, 2023
@shaynie shaynie deleted the user/shaynie/cameraSettingsManager branch July 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants