Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Drop Python 3.6 support #4891

Merged
merged 5 commits into from
Dec 18, 2021
Merged

[python] Drop Python 3.6 support #4891

merged 5 commits into from
Dec 18, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Python 3.6 is reaching its End of Life next week and no need to support it anymore.
https://devguide.python.org/#branchstatus

@StrikerRUS StrikerRUS marked this pull request as ready for review December 16, 2021 15:36
jameslamb
jameslamb approved these changes Dec 18, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support it! Especially since other dependencies of lightgbm have already dropped support for Python 3.6, like numpy (https://github.com/numpy/numpy/blob/0302205105161c6bbae5d45fe4e7a5a624f0dbf4/setup.py#L410) and pandas (https://github.com/pandas-dev/pandas/blob/47eb2198896852e17005629ed82c18940a05e975/setup.cfg#L40).

@StrikerRUS
Copy link
Collaborator Author

other dependencies of lightgbm have already dropped support for Python 3.6

They have already dropped even Python 3.7 (EoL 2023-06-27), interesting...

@StrikerRUS StrikerRUS merged commit f47b34f into master Dec 18, 2021
@StrikerRUS StrikerRUS deleted the drop_py_36 branch December 18, 2021 14:26
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
Closed
13 tasks
@nzw0301 nzw0301 mentioned this pull request Jan 7, 2022
Closed
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@guolinke guolinke mentioned this pull request Jun 15, 2023
Merged
@jameslamb jameslamb mentioned this pull request Jun 30, 2023
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@chivee chivee Awaiting requested review from chivee

@henry0312 henry0312 Awaiting requested review from henry0312

@hzy46 hzy46 Awaiting requested review from hzy46

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@tongwu-sh tongwu-sh Awaiting requested review from tongwu-sh

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StrikerRUS @jameslamb