-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] add start_iteration to python predict interface (#3058) #3272
Conversation
3a6e0af
to
5b7c0ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shiyu1994 Thank you very much! Just some minor comments regarding Python part.
Also, I believe sklearn wrapper should be updated with explicit parameter:
LightGBM/python-package/lightgbm/sklearn.py
Line 615 in a9f5654
def predict(self, X, raw_score=False, num_iteration=None, |
LightGBM/python-package/lightgbm/sklearn.py
Line 835 in a9f5654
def predict(self, X, raw_score=False, num_iteration=None, |
LightGBM/python-package/lightgbm/sklearn.py
Line 848 in a9f5654
def predict_proba(self, X, raw_score=False, num_iteration=None, |
@shiyu1994 Also, please add some tests that checks new param is working. Letting know @imatiach-msft about changes in SWIG API. |
ping @shiyu1994 for R's test fails:
|
@shiyu1994 it seems there are some lint/doc problems. |
@jameslamb @StrikerRUS Could you tell me how to update the R documentation in R-package/man folder? It seems that the tests failed due to code/doc mismatch. I try to use roxygen2 and run roxygenise under R-package folder but the following error occurs. Thanks. |
@shiyu1994 |
It seems that |
8cb28e0
to
e19742c
Compare
I think |
also
|
Thank you so much @shiyu1994 |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Suggested by Issue #3058. Add start_iteration for python prediction.