Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary semicolon #3260

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jul 29, 2020

Looking at the logs from #629 (comment), I noticed many instances of this:

In file included from ./include/LightGBM/utils/common.h:9:0,
                 from ./include/LightGBM/config.h:16,
                 from io/config_auto.cpp:8:
./include/LightGBM/utils/openmp_wrapper.h:84:2: warning: extra ‘;’ [-Wpedantic]
 };  // extern "C"

Uses of extern "C" {} don't need a closing ;.

This PR proposes removing the trailing ; in openmp_wrapper.h to suppress this compiler warning when using -pedantic.

You can see the R Hub logs here: https://builder.r-hub.io/status/original/lightgbm_2.3.2.tar.gz-6d1aa84ffbbd409293c9dcd94714bb47

@jameslamb jameslamb merged commit 1cf13db into microsoft:master Jul 29, 2020
@jameslamb jameslamb deleted the fix/pedantic branch October 11, 2020 04:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants