[R-package] Add tests on lgb.check.eval, lgb.unloader, and lgb.encode.char #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Jul 20, 2020
StrikerRUS
reviewed
Jul 22, 2020
Comment on lines
+92
to
+108
| test_that("lgb.check.eval adds eval to metric in params", { | ||
| params <- lgb.check.eval( | ||
| params = list(metric = "auc") | ||
| , eval = "binary_error" | ||
| ) | ||
| expect_named(params, "metric") | ||
| expect_identical(params[["metric"]], list("auc", "binary_error")) | ||
| }) | ||
|
|
||
| test_that("lgb.check.eval adds eval to metric in params", { | ||
| params <- lgb.check.eval( | ||
| params = list(metric = "auc") | ||
| , eval = "binary_error" | ||
| ) | ||
| expect_named(params, "metric") | ||
| expect_identical(params[["metric"]], list("auc", "binary_error")) | ||
| }) |
There was a problem hiding this comment.
@jameslamb These two tests look identical. Is it expected or just copy-paste issue?
There was a problem hiding this comment.
oh yes! Must be a copy-paste mistake. This is where I miss Python tests, where each test is a named function and a linter can warn you if you have two with the same name
| @@ -311,17 +309,26 @@ lgb.check.obj <- function(params, obj) { | |||
|
|
|||
| } | |||
|
|
|||
| # [description] | |||
| # make sure that "metric" is populated on params, | |||
| # and add any eval values to itt | |||
There was a problem hiding this comment.
to itt -> to it
In case you will create a PR to remove duplicated test, you can fix this typo at the same time 😃
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding a few more tests on R code that isn't currently covered by tests.
It also proposes fixing an inconsistency I found while writing the tests. Today
lgb.check.eval()sometimes setsmetricas a character vector, and sometimes sets it as a list. This PR fixes that and guarantees that it always uses a list. Alistis preferred because it allows for mixing string metric names and custom eval function objects.