[R-package] add test on importance types #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
force-pushed
the
r/importance-type-tests
branch
from
79f6e54 to
e4f230c
Compare
guolinke
approved these changes
Jul 20, 2020
StrikerRUS
reviewed
Jul 20, 2020
| test_that("Saving a model with different feature importance types works", { | ||
| set.seed(708L) | ||
| data(agaricus.train, package = "lightgbm") | ||
| data(agaricus.test, package = "lightgbm") |
There was a problem hiding this comment.
Sorry for commenting in the closed PR, but is seems that test data is not used in this test.
There was a problem hiding this comment.
blegh yeah I copied and pasted from other tests. Cut out the valids since it wasn't necessary, but I forgot to remove the test data. I'll just bundle that into #3240
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a test for the R package on the configuration of feature types introduced in #3220 .