Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix R CMD check NOTE about leftover files #3181

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

jameslamb
Copy link
Collaborator

This fixes the following NOTE from R CMD check on Windows:

checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
'data.bin' 'lgb-Dataset.data' 'lgb-model.rds' 'lgb-model.txt'
'lgb.Dataset.data' 'model.rds' 'model.txt'

It fixes this by only using tempfile() files everywhere that examples and tests write to the file system.

It also cleans up the logs in Windows R jobs. As of #3168 , I used {processx} to run some commands and redirect stderr, to avoid transient failures.

That produces hard-to-read logs like this:

image

This PR resolves that by assigning the result of processx::run() and setting echo = TRUE in those calls too stream out the logs.

@jameslamb jameslamb requested review from Laurae2 and guolinke June 23, 2020 03:21
@jameslamb jameslamb requested a review from StrikerRUS as a code owner June 23, 2020 03:21
@jameslamb
Copy link
Collaborator Author

it looks like this did eliminate the NOTE! https://github.com/microsoft/LightGBM/pull/3181/checks?check_run_id=797820357

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@jameslamb jameslamb merged commit be85f56 into microsoft:master Jun 23, 2020
@jameslamb jameslamb deleted the ci/windows-note branch July 12, 2020 21:43
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants