-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding static library option #3171
Conversation
I guess this piece of code should be updated as well: Lines 216 to 220 in e83042f
|
I believe the shared library suffix code should be fine as is since I don't think CMAKE_SHARED_LIBRARY_SUFFIX is used explicitly anywhere. |
@dpayne I mean, |
Apple should only be using DYLIB when building the shared library. I know this isn't definitive but at least on my local mac book I get |
@dpayne I apologize for the inconvenience, but could you please merge the most recent changes from We have had some recent changes to our continuous integration setup that you'll need for this PR to pass checks. Thanks for using and contributing to |
very cool, static library is necessary ! |
…dd_static_lib_option
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This adds a cmake option to build the library statically which is useful when linking into a static executable. The option is disabled by default.