Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] characterize all cmake messages #3105

Merged
merged 1 commit into from
May 20, 2020

Conversation

jameslamb
Copy link
Collaborator

I've noticed in the logs from running Rscript build_r.R that one log message seems misaligned

-- Check for working CXX compiler: /usr/local/clang-7.0.0/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
R version passed into FindLibR.cmake: 3.6.3
-- Found LibR: /usr/lib/R  
-- LIBR_EXECUTABLE: /usr/bin/R
-- LIBR_INCLUDE_DIRS: /usr/share/R/include
-- LIBR_CORE_LIBRARY: /usr/lib/R/lib/libR.so

I looked into it tonight, and this is because the "R version passed into..."message produced inFindLibR.cmakeis not characterized. In other words, it is usingmessage("R version...")instead ofmessage(STATUS "R version...")`.

This PR proposes characterizing this and one other message produced by CMake when building the R package. That line is not special and it shouldn't be drawing any special attention in the log.

@jameslamb jameslamb requested a review from StrikerRUS May 20, 2020 04:59
@jameslamb jameslamb requested a review from Laurae2 as a code owner May 20, 2020 04:59
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StrikerRUS StrikerRUS merged commit 5539e5a into microsoft:master May 20, 2020
@jameslamb jameslamb deleted the misc/cmake-messages branch June 7, 2020 19:29
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 10, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants