-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [ci] Fix CI timeouts for Mac builds on Travis (fixes #3091) #3092
Conversation
Tested on my fork, the Mac build takes almost 19 minutes but doesn't time out: https://travis-ci.com/github/jameslamb/LightGBM/jobs/335519105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general! Thanks!
Left two point for consideration.
Co-authored-by: Nikita Titov <[email protected]>
…osoft#3091) (microsoft#3092) * [R-package] use processx to speed up builds * different fix * echoing more frequently * fix it * more stdout * use print() instead of message() * shell tricks * fix message * travis * Update .ci/test_r_package.sh Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Nikita Titov <[email protected]>
…osoft#3091) (microsoft#3092) * [R-package] use processx to speed up builds * different fix * echoing more frequently * fix it * more stdout * use print() instead of message() * shell tricks * fix message * travis * Update .ci/test_r_package.sh Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Nikita Titov <[email protected]>
…osoft#3091) (microsoft#3092) * [R-package] use processx to speed up builds * different fix * echoing more frequently * fix it * more stdout * use print() instead of message() * shell tricks * fix message * travis * Update .ci/test_r_package.sh Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Nikita Titov <[email protected]>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
See #3091 for details. This PR fixes the recent issues with R Mac builds timing out on Travis.
It's not clear why these builds, which used to take around 10 minutes total, now take closer to 19 minutes
I'm a little worried that recent R PRs introduced a Mac installation performance problem, but I've also found (across many projects, not just LightGBM), that the Mac environments on Travis are not as reliable as the Linux environments.
Either way, that investigation can come later...this PR should unblock us.