Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] Removed unused constant in R_object_helper.h #2994

Merged
merged 2 commits into from
Apr 15, 2020
Merged

[R-package] Removed unused constant in R_object_helper.h #2994

merged 2 commits into from
Apr 15, 2020

Conversation

jameslamb
Copy link
Collaborator

I noticed this constant TYPE_BITS defined in R_object_helper.h. It isn't used anywhere (git grep TYPE_BITS) so I think we can remove it.

@jameslamb jameslamb requested review from Laurae2 and guolinke April 13, 2020 03:24
@jameslamb jameslamb merged commit 381c297 into microsoft:master Apr 15, 2020
@jameslamb jameslamb deleted the r/cleanup branch April 25, 2020 17:09
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @guolinke