Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix Booster read/write locale dependency (#2891)" #2980

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Revert "Fix Booster read/write locale dependency (#2891)" #2980

merged 1 commit into from
Apr 12, 2020

Conversation

henry0312
Copy link
Contributor

This reverts commit 6b68967 (#2891) and fixes #2979.

@henry0312 henry0312 requested a review from guolinke April 7, 2020 14:02
@henry0312 henry0312 requested a review from chivee as a code owner April 7, 2020 14:02
@henry0312 henry0312 self-assigned this Apr 7, 2020
@henry0312
Copy link
Contributor Author

henry0312 commented Apr 7, 2020 •
edited
Loading

Please read #2979.
I hope you will understand that #2891 is a wrong way to fix the SWIG problem and it breaks a lot of user enviroment.
That will also lead to many issues to be reported if next version is released.
For now, because the commit is only in master, users don't notice the locale issue.

@guolinke
Copy link
Collaborator

guolinke commented Apr 7, 2020

ping @AlbertoEAF

@henry0312 henry0312 changed the title Fix user locale settings Revert "Fix Booster read/write locale dependency (#2891)" Apr 9, 2020
@henry0312
Copy link
Contributor Author

ping @guolinke

@jameslamb jameslamb added the fix label Apr 10, 2020
@AlbertoEAF
Copy link
Contributor

As we discussed I agree with reverting my commit until we understand what is going on with Python's locale interaction: #2979 (comment)

@guolinke guolinke merged commit 8c33535 into microsoft:master Apr 12, 2020
@henry0312 henry0312 deleted the fix_locale branch April 12, 2020 03:55
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@chivee chivee Awaiting requested review from chivee

Assignees

@henry0312 henry0312

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CRITICAL BUG][Python] cannot wrire() UTF-8 strings by UnicodeEncodeError
4 participants
@henry0312 @guolinke @AlbertoEAF @jameslamb