replace built-in assert with own CHECK macro

[StrikerRUS]

It removes the difference between R-specific library and ordinary one.

Refer to #2837.

[jameslamb]

Hey great idea! Why is LightGBM::Log required for this?

[StrikerRUS]

@jameslamb

Why is LightGBM::Log required for this?

Because Json11 uses its own namespace

LightGBM/include/LightGBM/utils/json11.h

Line 59 in 0341906

namespace json11 {

and Log is defined in LightGBM namespace

LightGBM/include/LightGBM/utils/log.h

Line 24 in 0341906

namespace LightGBM {

Refer to https://stackoverflow.com/a/11791202.

[jameslamb]

@jameslamb

Why is LightGBM::Log required for this?

Because Json11 uses its own namespace

LightGBM/include/LightGBM/utils/json11.h

Line 59 in 0341906

namespace json11 {

and Log is defined in LightGBM namespace

LightGBM/include/LightGBM/utils/log.h

Line 24 in 0341906

namespace LightGBM {

Refer to https://stackoverflow.com/a/11791202.

oooooooh wild, ok! thanks for the explanation

[jameslamb]

Looks good to me. I can see in the logs that this did not introduce any new R CMD CHECK issues.

[jameslamb]

@chivee or @guolinke could you take a look and let us know if you are ok with this?

Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.