Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix VS project files #2924

Merged
merged 2 commits into from
Mar 19, 2020
Merged

[ci] fix VS project files #2924

merged 2 commits into from
Mar 19, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #2891.

jameslamb
jameslamb approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! yep good catch. Is there any way we could catch this in CI? or is it not worth it

@StrikerRUS StrikerRUS merged commit e32d34a into master Mar 19, 2020
@StrikerRUS
Copy link
Collaborator Author

@jameslamb

Is there any way we could catch this in CI?

I don't know any 🙁

or is it not worth it

I guess, yes.

@StrikerRUS StrikerRUS deleted the vs_fix branch March 19, 2020 11:40
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@jameslamb jameslamb jameslamb approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrikerRUS @jameslamb @guolinke