[R-package] fixed handling of multiple evaluation metrics (fixes #2913) #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the linked issue for details. Training with multiple evaluation metrics is currently broken in the R package, for all cases where the metrics have a different number of characters (e.g.
c("auc", "binary_logloss").We may not have caught this until now because the bug doesn't show up if the metrics have the same number of characters, e.g.
c("l1", "l2")orc("rmse", "mape").I've added tests in this PR which should prevent us from re-introducing this bug.
I also added explicit uses of
return()inlgb.params2str()just to make that function a bit more explicit.