Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] update latest benchmark results #2887

Merged
merged 5 commits into from
Mar 8, 2020
Merged

[docs] update latest benchmark results #2887

merged 5 commits into from
Mar 8, 2020

Conversation

guolinke
Copy link
Collaborator

@guolinke guolinke commented Mar 8, 2020

No description provided.

guolinke
guolinke commented Mar 8, 2020
View reviewed changes
docs/Experiments.rst Outdated Show resolved Hide resolved
@Laurae2
Copy link
Contributor

Laurae2 commented Mar 8, 2020

@guolinke Which commits of xgboost / LightGBM did you use for the benchmarks?

@guolinke
Copy link
Collaborator Author

guolinke commented Mar 8, 2020

@Laurae2 I add the commit hash in the doc.
The XGBoost version includes all their recent efficiency improvements.

@StrikerRUS
Copy link
Collaborator

@guolinke Very impressive!
What about Parallel Experiment? I think it should be updated as well or be marked as from first version.

@StrikerRUS StrikerRUS added the doc label Mar 8, 2020
@guolinke
Copy link
Collaborator Author

guolinke commented Mar 8, 2020

@StrikerRUS as we didn't improve parallel algorithm, we can mark them to first version

@StrikerRUS StrikerRUS changed the title update latest benchmark results [docs] update latest benchmark results Mar 8, 2020
@guolinke guolinke merged commit 6b6709b into master Mar 8, 2020
@StrikerRUS StrikerRUS deleted the guolinke-patch-1 branch March 8, 2020 18:35
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guolinke @Laurae2 @StrikerRUS