[R-package] [ci] added tests on early_stopping #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Mar 2, 2020
jameslamb
force-pushed
the
ci/r-early-stopping-tests
branch
from
55ec50c to
3af13ab
Compare
jameslamb
force-pushed
the
ci/r-early-stopping-tests
branch
from
3af13ab to
53951f1
Compare
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't have unit tests on the R package that check that early_stopping is working correctly. This is an important area to cover, since it involves some non-standard environment editing with
<<-and since it requires context switching between 0-based indexing (fromlib_lightgbm) and 1-base indexing (the R code).I also want to be sure we have these tests before I start on #2368